fix: retry Get for 500 and 503 error from GCE metadata server #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baeminbo
requested review from
arithmetic1728,
sai-sunder-s and
a team
as code owners
|
link with issue #980 |
|
@arithmetic1728 The #980 is about token endpoint, while this change addresses retries to Metadata endpoint |
|
@arithmetic1728 i think we need first to address the #980 and add Retryable interface, then we can leverage that here to address Metadata retries. Most likely we will opt for retryable errors passed to client instead of actual retries in the library. |
|
@baeminbo Hi, could you, please, provide any stats on Metadata service errors that you are trying to mitigate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, getting metadata retries only for a transport error, but doesn't retry for retryable status code.
GCE metadata doc suggests retrying for 503. In addition, GCE metadata server also returns 500 error for intermittent unavailability.
If this happens in token refresh, an intermittent 500 or 503 error is propagated as
RefreshError.RefreshErroris not retryable inpython-api-corelibrary. So, just one time of an intermittent retryable error with GCE metadata leads to GCP API call failure.To mitigate this, I asked retry of
RefreshErrorat [1], but the team suggested adding retry atauthlayer [2].[1] googleapis/python-api-core#312
[2] googleapis/python-api-core#313 (comment)