Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: aws path normalization in windows #842

Merged
merged 2 commits into from Aug 17, 2021
Merged

fix: aws path normalization in windows #842

merged 2 commits into from Aug 17, 2021

Commits on Aug 17, 2021

  1. fix: aws path normalization in windows 

    Path normalization for the canonical_uri was broken in windows.
This is because we were using `os.path.normpath`.
This normalizes "/" paths to "\\" in Windows OS.

Confirmed the fix is working in Windows.
    @bojeil-google
    bojeil-google committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    2eb9e80 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into aws-windows-fix

    @bojeil-google
    bojeil-google committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    79c3bc7 View commit details
    Browse the repository at this point in the history