Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not use the GAE APIs on gen2+ runtimes #807

Merged
merged 3 commits into from Jul 23, 2021
Merged

fix: do not use the GAE APIs on gen2+ runtimes #807

merged 3 commits into from Jul 23, 2021
+119 −8

Commits on Jul 23, 2021

  1. fix: do not use the GAE APIs on gen2+ runtimes 

    Currently, this library uses the App Engine API in all environments if
it can be imported successfully. This assumption made sense when the API
was only available on gen1, but this is no longer the case.
See https://github.com/GoogleCloudPlatform/appengine-python-standard

In order to comply with AIP-4115, we must treat GAE gen2+ as a "compute
engine equivalent environment" even if the GAE APIs are importable.
In other words, google.auth.default() must never return an
app_engine.Credental on GAE gen2+.Currently, this library uses the App Engine API in all environments if
it can be imported successfully. This assumption made sense when the API
was only available on gen1, but this is no longer the case.
See https://github.com/GoogleCloudPlatform/appengine-python-standard

In order to comply with AIP-4115, we must treat GAE gen2+ as a "compute
engine equivalent environment" even if the GAE APIs are importable.
In other words, google.auth.default() should not return an
app_engine.Credental on GAE gen2+.
    @zevdg
    zevdg committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    162ee03 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into gae-gen2-apis

    @arithmetic1728
    arithmetic1728 committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    cc3e244 View commit details
    Browse the repository at this point in the history

  3. blacken

    @zevdg
    zevdg committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    4a1ad52 View commit details
    Browse the repository at this point in the history