Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid losing the original _include_email parameter in impersonated credentials #626

Merged
merged 4 commits into from Dec 11, 2020
Merged

fix: avoid losing the original _include_email parameter in impersonated credentials #626

merged 4 commits into from Dec 11, 2020

Commits on Nov 11, 2020

  1. fix: avoid losing the original _include_email parameter 

    Fix on the Impersonated Credentials class.
In IDTokenCredentials.with_target_audience(),
IDTokenCredentials.from_credentials(),
don't discard the original self._include_email parameter.
    @pietrodn
    pietrodn committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    493dab6 View commit details
    Browse the repository at this point in the history

  2. test: check that IDTokenCredentials._include_email is preserved

    @pietrodn
    pietrodn committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    4f14bc1 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Merge branch 'master' into patch-1

    @tseaver
    tseaver committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    2f3e9b6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into patch-1

    @tseaver
    tseaver committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    690e946 View commit details
    Browse the repository at this point in the history