fix(deps): use mock from stdlib in tests #488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
maxwell-k
changed the title
maxwell-k
changed the title
This change removes an unnecessary dependency in the tests. The [mock package] is a backport of functionality from the Python 3.3 standard library to Python 2.7. google-auth-library-python is [not supported] on Python 2.7. Using `import mock` instead of `from unittest import mock` adds an unnecessary dependency, for no apparent gain. [mock package]: https://pypi.org/project/mock/ [not supported]: https://github.com/googleapis/google-auth-library-python#deprecated-python-versions
|
@maxwell-k Thanks for the patch. However, Python 2.7 support is deprecated, but still present. Until we drop it entirely (including from CI / nox), we cannot rely on the stdlib to have |
tseaver
added
the
do not merge
tseaver
requested review from
arithmetic1728,
silvolu and
a team
as code owners
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
@maxwell-k I'm sorry not to be able to merge this PR. While working on #778, I found that we cannot drop the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes an unnecessary dependency in the tests.
The mock package is a backport of functionality from the Python 3.3 standard library to Python 2.7. This library is not supported on Python 2.7. Using
import mockinstead offrom unittest import mockadds an unnecessary dependency, for no apparent gain.