Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove content-type header from IDMS GET requests #1489

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: Remove content-type header from IDMS GET requests #1489

wants to merge 5 commits into from

Conversation

peter-volkov
Copy link

@peter-volkov peter-volkov commented Mar 5, 2024 •
edited

@peter-volkov peter-volkov requested review from a team as code owners March 5, 2024 12:43
@google-cla Google CLA
Copy link

google-cla bot commented Mar 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@peter-volkov peter-volkov changed the title Remove content-type header from IDMS GET requests fix: Remove content-type header from IDMS GET requests Mar 5, 2024
@peter-volkov peter-volkov mentioned this pull request Mar 5, 2024
Merged
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 5, 2024
@parthea
Copy link
Contributor

parthea commented Mar 5, 2024

See googleapis/google-cloud-go#9508 (comment)

BigTailWolf
BigTailWolf approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@BigTailWolf BigTailWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BigTailWolf BigTailWolf added kokoro:force-run Add this label to force Kokoro to re-run the tests. api: workflows Issues related to the Workflows API. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 5, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2024
@BigTailWolf
Copy link
Contributor

See googleapis/google-cloud-go#9508 (comment)

Hi Anthonios, the golang/oauth2 library is merged. And seems this fix is also good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigTailWolf BigTailWolf BigTailWolf approved these changes

Assignees
No one assigned
Labels
api: workflows Issues related to the Workflows API. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peter-volkov @parthea @BigTailWolf @yoshi-kokoro