Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect correct auth when ADC env var is set but empty #1374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbrancato
Copy link

Treat empty strings as if the env var was not set. This fixes an issue where an environment variable for GOOGLE_APPLICATION_CREDENTIALS is set, but it empty. Because the default sentinel is None, the auth library attempts to load this file. Some systems can set or update an env var, but not unset an env var (e.g. Docker).

Fixes: googleapis/python-pubsub#983

@mbrancato mbrancato requested review from a team as code owners August 22, 2023 16:30
@google-cla
Copy link

google-cla bot commented Aug 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default credentials fail to detect running on GCP when ADC env var is empty
2 participants