feat: add httpx transport; add compute_engine async #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bkanuka
changed the title
|
Super cool! I will give this a thorough read later. Two high level questions I have for you.
|
|
Oh this is exactly what I'd need. httpx is such a brilliant library, it would be awesome of the Google auth client could natively support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a draft PR to gauge interest in adding an httpx transport.
This is used internally for a project that otherwise relied on httpx (instead of aiohttp) for async http requests. Using this httpx transport means that the response from an
AuthorisedSessionis anhttpx.Resposelike the other responses in our code.Frankly, this a copy/paste job from
_aiohttp_requests.pywith relevant parts changed.compute_engine._credentials_async.pyis also added for async Compute Engine credentials. Arguably, this should be discussed separately, but was created while developing the httpx transport.There is more work to be done before this could merge, but please discuss and provide feedback.