Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: response content is empty when using cache #1248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yanxurui
Copy link

I am using this library in a project and found there is an issue when combined with cache.

Check the example below:

import asyncio
import aiohttp
from aiohttp_client_cache import CachedSession, CacheBackend


async def main():
    request_cache = CacheBackend(expire_after=60*60)
    async with CachedSession(cache=request_cache, auto_decompress=False) as s:
    # async with aiohttp.ClientSession() as s:
        while True:
            resp = await s.request('GET', 'https://www.googleapis.com/oauth2/v1/certs')
            content = await resp.content.read()
            body = await resp.read()
            import pdb
            pdb.set_trace()

# call main() in a loop
loop = asyncio.get_event_loop()
loop.run_until_complete(main())

In the 3rd iteration of the loop above, content will be an empty string while body is expected. This is probably because the content stream was GCed. Use .read() instead of .content.read() can fix the problem.

@yanxurui yanxurui requested review from a team as code owners March 14, 2023 14:23
@google-cla
Copy link

google-cla bot commented Mar 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant