Cleanup dependencies since only Python ≥ 3.6 is supported #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietrodn
requested review from
arithmetic1728,
sai-sunder-s and
a team
as code owners
|
I'm not sure if we can drop support for python 2.7 as it was re-introduced in #892 after being dropped. According to #892 this was meant to be temporary. I've assigned this PR to @sai-sunder-s to take a look. |
|
How can you be sure it is actually working? Tests don't even run for Python 2.7, it's very easy to introduce a breaking change. 🤔 |
|
Kokoro runs unit tests for python 2.7 (https://github.com/googleapis/google-auth-library-python/blob/main/noxfile.py#L107). If gcloud drops 2.7 then I think we can drop 2.7 support as well. I think @sai-sunder-s has more context on gcloud. |
|
Thank you for your contribution! Closed in favor of #1301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README states that only Python ≥ 3.6 is supported.
Therefore, we can remove all the dependencies conditioned to older versions of Python from the
setup.py.The Python version constraint can also be simplified.