docs: Fix secure_authorized_channel argument positions. #1136
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
requested review from
arithmetic1728,
sai-sunder-s and
a team
as code owners
clundin25
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
kokoro:run
salrashid123
reviewed
Sep 6, 2022
| @@ -132,7 +132,7 @@ def secure_authorized_channel( | |||
|
|
|||
| # Create a channel. | |||
| channel = google.auth.transport.grpc.secure_authorized_channel( | |||
| credentials, regular_endpoint, request, | |||
| credentials, request, regular_endpoint, | |||
There was a problem hiding this comment.
why use posisional args again here? woudn't it be clearer using the names itself for clarity request=request, regular_endpoint=...)
There was a problem hiding this comment.
I don't feel particularly strongly about this, but switching to keyword arguments would go against the style of the rest of the codebase.
There was a problem hiding this comment.
sure, but using incorrect positional led to filing this bug. apart from styleguide stuff, the better way to think about it is what would be the best for the customer/reader
clundin25
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves
#1130.