Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): pin TypeScript below 3.7.0 #845

Merged
merged 2 commits into from
Dec 5, 2019
Merged

fix(deps): pin TypeScript below 3.7.0 #845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c68e5d
fix(deps): TypeScript 3.7.0 causes breaking change in typings
bcoe Dec 5, 2019
493e215
chore: remove optional chaining
bcoe Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"source-map-support": "^0.5.6",
"tmp": "^0.1.0",
"ts-loader": "^6.0.0",
"typescript": "~3.7.0",
"typescript": "3.6.4",
"webpack": "^4.20.2",
"webpack-cli": "^3.1.1"
},
Expand Down
3 changes: 2 additions & 1 deletion renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@
"extends": "packages:linters",
"groupName": "linters"
}
]
],
"ignoreDeps": ["typescript"]
}
2 changes: 1 addition & 1 deletion src/auth/oauth2client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,7 @@ export class OAuth2Client extends AuthClient {
try {
const r = await this.getRequestMetadataAsync(opts.url);
opts.headers = opts.headers || {};
if (r.headers?.['x-goog-user-project']) {
if (r.headers && r.headers['x-goog-user-project']) {
opts.headers['x-goog-user-project'] = r.headers['x-goog-user-project'];
}
if (r.headers && r.headers.Authorization) {
Expand Down