feat: use self-signed JWTs if alwaysUseJWTAccessWithScope is true #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
sofisl
added
the
do not merge
|
Still need to add tests |
JustinBeckwith
suggested changes
Jul 1, 2021
|
@bcoe @JustinBeckwith, comments have been addressed & tests added! |
gcf-owl-bot
bot
removed
the
owlbot:run
bcoe
approved these changes
Aug 26, 2021
bcoe
removed
the
do not merge
bshaffer
reviewed
Aug 27, 2021
bcoe
suggested changes
Aug 27, 2021
Co-authored-by: Brent Shaffer <betterbrent@google.com>
bcoe
reviewed
Aug 30, 2021
bcoe
approved these changes
Aug 30, 2021
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
google-cla
bot
added
cla: no
bcoe
added
cla: yes
bshaffer
approved these changes
Aug 30, 2021
sofisl
changed the title
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 30, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [7.8.0](https://www.github.com/googleapis/google-auth-library-nodejs/compare/v7.7.0...v7.8.0) (2021-08-30) ### Features * use self-signed JWTs if alwaysUseJWTAccessWithScope is true ([#1196](https://www.github.com/googleapis/google-auth-library-nodejs/issues/1196)) ([ad3f652](https://www.github.com/googleapis/google-auth-library-nodejs/commit/ad3f652e8e859d8d8a69dfe9df01d001862fe0ae)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for the self-signed JWT implementation
In conjunction with: googleapis/gapic-generator-typescript#908