Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove deprecated methods #906

Merged
merged 5 commits into from Mar 21, 2020
Merged

chore!: remove deprecated methods #906

merged 5 commits into from Mar 21, 2020

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Feb 29, 2020 •
edited

Fixes #704

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 29, 2020
@bcoe bcoe added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 2, 2020
@bcoe
Copy link
Contributor

bcoe commented Mar 2, 2020

This looks reasonable to me, but I would like to release:

#909

First, and give this a chance to bake, it being 4PM, realistically I don't think we should put out #909 until the morning.

@JustinBeckwith
Copy link
Contributor Author

I'm ok holding off until the next major release. J was starting to line some of these up to get on master for the node 8 deprecation.

@JustinBeckwith JustinBeckwith removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 21, 2020
@codecov
Copy link

codecov bot commented Mar 21, 2020 •
edited

Codecov Report

Merging #906 into master will decrease coverage by 2.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #906     +/-   ##
=========================================
- Coverage   94.13%   91.63%   -2.5%     
=========================================
  Files          19       19             
  Lines        4208     4007    -201     
  Branches      490      409     -81     
=========================================
- Hits         3961     3672    -289     
- Misses        247      332     +85     
- Partials        0        3      +3
Impacted Files Coverage Δ
src/auth/googleauth.ts 95.67% <ø> (-1.54%) ⬇️
src/auth/computeclient.ts 100% <ø> (ø) ⬆️
src/messages.ts 0% <ø> (-97.46%) ⬇️
src/auth/jwtclient.ts 94.13% <ø> (-2.89%) ⬇️
src/auth/jwtaccess.ts 98.36% <ø> (-0.23%) ⬇️
src/auth/iam.ts 100% <ø> (ø) ⬆️
src/auth/oauth2client.ts 94.26% <ø> (-1.67%) ⬇️
src/auth/envDetect.ts 93.42% <0%> (-3.95%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d337131...e8a95c4. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit f453fb7 into master Mar 21, 2020
@release-please release-please bot mentioned this pull request Mar 21, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 26, 2020
@release-please
chore: release 6.0.0 (#920)
41b0cb7 
🤖 I have created a release \*beep\* \*boop\* 
---
## [6.0.0](https://www.github.com/googleapis/google-auth-library-nodejs/compare/v5.10.1...v6.0.0) (2020-03-26)


### ⚠ BREAKING CHANGES

* typescript@3.7.x introduced some breaking changes in
generated code.
* require node 10 in engines field (#926)
* remove deprecated methods (#906)

### Features

* require node 10 in engines field ([#926](https://www.github.com/googleapis/google-auth-library-nodejs/issues/926)) ([d89c59a](https://www.github.com/googleapis/google-auth-library-nodejs/commit/d89c59a316e9ca5b8c351128ee3e2d91e9729d5c))


### Bug Fixes

* do not warn for SDK creds ([#905](https://www.github.com/googleapis/google-auth-library-nodejs/issues/905)) ([9536840](https://www.github.com/googleapis/google-auth-library-nodejs/commit/9536840f88e77f747bbbc2c1b5b4289018fc23c9))
* use iamcredentials API to sign blobs ([#908](https://www.github.com/googleapis/google-auth-library-nodejs/issues/908)) ([7b8e4c5](https://www.github.com/googleapis/google-auth-library-nodejs/commit/7b8e4c52e31bb3d448c3ff8c05002188900eaa04))
* **deps:** update dependency gaxios to v3 ([#917](https://www.github.com/googleapis/google-auth-library-nodejs/issues/917)) ([1f4bf61](https://www.github.com/googleapis/google-auth-library-nodejs/commit/1f4bf6128a0dcf22cfe1ec492b2192f513836cb2))
* **deps:** update dependency gcp-metadata to v4 ([#918](https://www.github.com/googleapis/google-auth-library-nodejs/issues/918)) ([d337131](https://www.github.com/googleapis/google-auth-library-nodejs/commit/d337131d009cc1f8182f7a1f8a9034433ee3fbf7))
* **types:** add additional fields to TokenInfo ([#907](https://www.github.com/googleapis/google-auth-library-nodejs/issues/907)) ([5b48eb8](https://www.github.com/googleapis/google-auth-library-nodejs/commit/5b48eb86c108c47d317a0eb96b47c0cae86f98cb))


### Build System

* update to latest gts and TypeScript ([#927](https://www.github.com/googleapis/google-auth-library-nodejs/issues/927)) ([e11e18c](https://www.github.com/googleapis/google-auth-library-nodejs/commit/e11e18cb33eb60a666980d061c54bb8891cdd242))


### Miscellaneous Chores

* remove deprecated methods ([#906](https://www.github.com/googleapis/google-auth-library-nodejs/issues/906)) ([f453fb7](https://www.github.com/googleapis/google-auth-library-nodejs/commit/f453fb7d8355e6dc74800b18d6f43c4e91d4acc9))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

retire deprecated methods
4 participants
@JustinBeckwith @bcoe @bshaffer @googlebot