feat: Make full implementation on DownscopedClient. #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
Seems like this code was copied from other classes. I remember a thread in the cab doc that mentioned a refactor. Did that change? |
There're 2 approaches copy vs refactor. In short term, it is easier to just copy from baseExternalClient. |
bojeil-google
suggested changes
Aug 31, 2021
bojeil-google
approved these changes
Aug 31, 2021
bcoe
suggested changes
Sep 1, 2021
bcoe
approved these changes
Sep 2, 2021
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [7.9.0](https://www.github.com/googleapis/google-auth-library-nodejs/compare/v7.8.0...v7.9.0) (2021-09-02) ### Features * wire up implementation of DownscopedClient. ([#1232](https://www.github.com/googleapis/google-auth-library-nodejs/issues/1232)) ([baa1318](https://www.github.com/googleapis/google-auth-library-nodejs/commit/baa13185836bb299b769c034bfb7d37231eea8d1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This full implementation for downscoped client is just to satisfy requirement of the abstract class AuthClient, this is neither urgent and nor a blocker in terms of functionality since they're not expected to be used by token brokers.
Three components are added:
These implementations are mostly copied from BaseExternalClient.