feat: Adds support for STS response not returning expires_in field. #1216

xil222 · 2021-07-21T18:35:30Z

stsResponse doesnt return expire_in if subject_token isnt service account access token.
Change the expire_in field to optional and add changes to downscopedclient and baseexternalclient.
bug: b/193924974
Your feedback is greatly appreciated! @bojeil-google @bcoe

…brary-nodejs into expireTime

src/auth/downscopedclient.ts

test/test.baseexternalclient.ts

test/test.downscopedclient.ts

* fix: update TODO section * remove origin * Update idtokens-serverless.js

🤖 I have created a release \*beep\* \*boop\* --- ## [7.4.0](https://www.github.com/googleapis/google-auth-library-nodejs/compare/v7.3.0...v7.4.0) (2021-07-29) ### Features * **impersonated:** add impersonated credentials auth ([googleapis#1207](https://www.github.com/googleapis/google-auth-library-nodejs/issues/1207)) ([ab1cd31](https://www.github.com/googleapis/google-auth-library-nodejs/commit/ab1cd31e07d45424f614e0401d1068df2fbd914c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…n. (googleapis#1219)

🤖 I have created a release \*beep\* \*boop\* --- ### [7.4.1](https://www.github.com/googleapis/google-auth-library-nodejs/compare/v7.4.0...v7.4.1) (2021-07-29) ### Bug Fixes * **downscoped-client:** bug fixes for downscoped client implementation. ([googleapis#1219](https://www.github.com/googleapis/google-auth-library-nodejs/issues/1219)) ([4fbe67e](https://www.github.com/googleapis/google-auth-library-nodejs/commit/4fbe67e08bce3f31193d3bb7b93c4cc1251e66a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

generated-files-bot · 2021-07-29T22:36:55Z

Warning: This pull request is touching the following templated files:

.github/CODEOWNERS - CODEOWNERS should instead be modified via the codeowner_team property in .repo-metadata.json
README.md - README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/master/.readme-partials.yaml

snippet-bot · 2021-07-29T22:37:01Z

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

google-cla · 2021-07-29T22:37:15Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

test/test.downscopedclient.ts

…brary-nodejs into expireTime

google-cla · 2021-07-30T20:55:21Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-07-30T20:56:50Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

bojeil-google

Thanks for putting this together. I mostly have suggestions and propose tweaks to the unit tests.

test/test.baseexternalclient.ts

test/test.downscopedclient.ts

…brary-nodejs into expireTime

google-cla · 2021-08-03T18:29:45Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

test/test.downscopedclient.ts

test/test.baseexternalclient.ts

google-cla · 2021-08-04T02:14:11Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-08-04T21:24:52Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

🤖 I have created a release \*beep\* \*boop\* --- ## [7.5.0](https://www.github.com/googleapis/google-auth-library-nodejs/compare/v7.4.1...v7.5.0) (2021-08-04) ### Features * Adds support for STS response not returning expires_in field. ([#1216](https://www.github.com/googleapis/google-auth-library-nodejs/issues/1216)) ([24bb456](https://www.github.com/googleapis/google-auth-library-nodejs/commit/24bb4568820c2692b1b3ff29835a38fdb3f28c9e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Adds support for stsResponse doesnt return expiry time.

f0895ef

xil222 requested a review from a team as a code owner July 21, 2021 18:35

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2021

xil222 changed the title ~~feat: Adds support for stsResponse doesnt return expiry time.~~ feat: Adds support for STS response not returning expires_in field. Jul 21, 2021

xil222 added 2 commits July 21, 2021 11:41

Adds support for STS response not returning expires_in field.

b245f0e

Merge branch 'expireTime' of https://github.com/xil222/google-auth-li…

77ab907

…brary-nodejs into expireTime

xil222 changed the title ~~feat: Adds support for STS response not returning expires_in field.~~ fix: Adds support for STS response not returning expires_in field. Jul 21, 2021

xil222 changed the title ~~fix: Adds support for STS response not returning expires_in field.~~ feat: Adds support for STS response not returning expires_in field. Jul 21, 2021

Merge branch 'master' into expireTime

2277ed4

bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2021

xil222 mentioned this pull request Jul 22, 2021

feat: Implement DownscopedClient#getAccessToken() and unit test #1201

Merged

lsirac reviewed Jul 28, 2021

View reviewed changes

src/auth/downscopedclient.ts Show resolved Hide resolved

test/test.baseexternalclient.ts Outdated Show resolved Hide resolved

test/test.downscopedclient.ts Outdated Show resolved Hide resolved

test/test.downscopedclient.ts Show resolved Hide resolved

bcoe and others added 11 commits July 29, 2021 15:11

meta: add nodejs-auth as codeowner (googleapis#1217)

bb2a430

samples: update TODO section (googleapis#1218)

b1f1094

* fix: update TODO section * remove origin * Update idtokens-serverless.js

feat(impersonated): add impersonated credentials auth (googleapis#1207)

59f6017

fix(downscoped-client): bug fixes for downscoped client implementatio…

549e518

…n. (googleapis#1219)

sample: update region tag (googleapis#1223)

682a859

Adds support for STS response not returning expires_in field.

84d434b

Adds support for stsResponse doesnt return expiry time.

241be27

Remove extra tests in baseExternalClient.

1c4b296

merge origin/expireTime

22afcec

xil222 requested a review from a team as a code owner July 29, 2021 22:36

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 29, 2021

Merge branch 'master' into expireTime

a7aa1aa

lsirac reviewed Jul 30, 2021

View reviewed changes

test/test.downscopedclient.ts Outdated Show resolved Hide resolved

xil222 added 2 commits July 30, 2021 13:54

change parsing expire_in logic in baseexternalclient.

91a4927

Merge branch 'expireTime' of https://github.com/xil222/google-auth-li…

c87fa70

…brary-nodejs into expireTime

Merge branch 'master' into expireTime

cc0e1d6

lsirac approved these changes Jul 30, 2021

View reviewed changes

bojeil-google suggested changes Jul 30, 2021

View reviewed changes

xil222 added 2 commits August 3, 2021 11:28

Add testAuthClient setter and tweak some tests.

26d194f

Merge branch 'expireTime' of https://github.com/xil222/google-auth-li…

5233611

…brary-nodejs into expireTime

bojeil-google suggested changes Aug 4, 2021

View reviewed changes

test/test.downscopedclient.ts Outdated Show resolved Hide resolved

test/test.baseexternalclient.ts Show resolved Hide resolved

add emit events for some tests.

af59d70

bojeil-google approved these changes Aug 4, 2021

View reviewed changes

bcoe added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 4, 2021

bcoe approved these changes Aug 4, 2021

View reviewed changes

Merge branch 'master' into expireTime

d314a21

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 4, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2021

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 4, 2021

bcoe merged commit 24bb456 into googleapis:master Aug 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Adds support for STS response not returning expires_in field. #1216

feat: Adds support for STS response not returning expires_in field. #1216

xil222 commented Jul 21, 2021 •

edited

generated-files-bot bot commented Jul 29, 2021

snippet-bot bot commented Jul 29, 2021 •

edited

google-cla bot commented Jul 29, 2021

google-cla bot commented Jul 30, 2021

google-cla bot commented Jul 30, 2021

bojeil-google left a comment

google-cla bot commented Aug 3, 2021

google-cla bot commented Aug 4, 2021

google-cla bot commented Aug 4, 2021

feat: Adds support for STS response not returning expires_in field. #1216

feat: Adds support for STS response not returning expires_in field. #1216

Conversation

xil222 commented Jul 21, 2021 • edited

generated-files-bot bot commented Jul 29, 2021

snippet-bot bot commented Jul 29, 2021 • edited

No region tags are edited in this PR.

google-cla bot commented Jul 29, 2021

google-cla bot commented Jul 30, 2021

google-cla bot commented Jul 30, 2021

bojeil-google left a comment

Choose a reason for hiding this comment

google-cla bot commented Aug 3, 2021

google-cla bot commented Aug 4, 2021

google-cla bot commented Aug 4, 2021

xil222 commented Jul 21, 2021 •

edited

snippet-bot bot commented Jul 29, 2021 •

edited