Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): include scope in credentials type #1007

Merged
merged 1 commit into from Jul 15, 2020
Merged

fix(types): include scope in credentials type #1007

merged 1 commit into from Jul 15, 2020

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Jul 15, 2020 •
edited

Fixes #1003

@JustinBeckwith JustinBeckwith requested a review from a team as a code owner July 15, 2020 04:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020 •
edited

Codecov Report

Merging #1007 into master will decrease coverage by 0.85%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
- Coverage   92.37%   91.51%   -0.86%     
==========================================
  Files          21       21              
  Lines        4052     4090      +38     
  Branches      454      454              
==========================================
  Hits         3743     3743              
- Misses        309      347      +38
Impacted Files Coverage Δ
src/auth/credentials.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad94be...64b77ca. Read the comment docs.

@JustinBeckwith JustinBeckwith mentioned this pull request Jul 15, 2020
Closed
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2020
@JustinBeckwith JustinBeckwith merged commit a2b7d23 into master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofisl sofisl sofisl approved these changes

Assignees

@sofisl sofisl

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing scope in Credentials interface
4 participants
@JustinBeckwith @sofisl @googlebot @yoshi-kokoro