Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing scope in Credentials interface #1003

Closed
Sytten opened this issue Jul 13, 2020 · 1 comment · Fixed by #1007
Closed

Missing scope in Credentials interface #1003

Sytten opened this issue Jul 13, 2020 · 1 comment · Fixed by #1007
Assignees
@JustinBeckwith
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Sytten
Copy link

Sytten commented Jul 13, 2020

The interface Credentials (https://github.com/googleapis/google-auth-library-nodejs/blob/master/src/auth/credentials.ts#L15) is missing the scope field which is a string.

See this documentation for the typical response: https://developers.google.com/identity/protocols/oauth2/openid-connect#exchangecode
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 14, 2020
@sofisl sofisl added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Jul 14, 2020
@JustinBeckwith JustinBeckwith mentioned this issue Jul 15, 2020
Merged
@JustinBeckwith
Copy link
Contributor

Good find! Fix ready over in #1007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): include scope in credentials type googleapis/google-auth-library-nodejs
5 participants
@bcoe @JustinBeckwith @Sytten @yoshi-automation @sofisl