fix: gcp-metadata now warns rather than throwing (#956)

googleapis · May 7, 2020 · 89e16c2 · 89e16c2
1 parent 0795540
commit 89e16c2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -22,7 +22,7 @@
     "ecdsa-sig-formatter": "^1.0.11",
     "fast-text-encoding": "^1.0.0",
     "gaxios": "^3.0.0",
-    "gcp-metadata": "^4.0.0",
+    "gcp-metadata": "^4.1.0",
     "gtoken": "^5.0.0",
     "jws": "^4.0.0",
     "lru-cache": "^5.0.0"

diff --git a/test/test.googleauth.ts b/test/test.googleauth.ts
@@ -1045,11 +1045,11 @@ describe('googleauth', () => {
       scopes.forEach(s => s.done());
     });
 
-    it('_checkIsGCE should throw on unexpected errors', async () => {
+    it('_checkIsGCE should return false on unexpected errors', async () => {
       assert.notStrictEqual(true, auth.isGCE);
       const scope = nock500GCE();
-      await assert.rejects(auth._checkIsGCE());
-      assert.strictEqual(undefined, auth.isGCE);
+      assert.strictEqual(await auth._checkIsGCE(), false);
+      assert.strictEqual(auth.isGCE, false);
       scope.done();
     });