Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Id token support for UserCredentials #650

Merged
merged 23 commits into from May 26, 2021
Merged
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
cb3866e
new adapter for idtoken
TimurSadykov May 6, 2021
ef781ec
Merge remote-tracking branch 'origin/master' into idtoken-cloudrun
May 6, 2021
9def95a
poc of the IdtokenProvider implementation for UserCredentials
May 6, 2021
3096bd0
removing HttpUserCredentialsAdapter as we go with IdTokenProvider app…
May 6, 2021
164821e
Merge remote-tracking branch 'origin/master' into idtoken-cloudrun
May 11, 2021
74b0994
fix build
May 11, 2021
195e37f
linter fixes
TimurSadykov May 11, 2021
9a0a669
linter fixes
TimurSadykov May 11, 2021
bce601b
actual linter fixes
TimurSadykov May 11, 2021
c1ea597
unit tests for idtoken
May 15, 2021
83cbd33
Merge branch 'idtoken-cloudrun' of https://github.com/googleapis/goog…
May 15, 2021
21b1c79
linter fixes
May 16, 2021
2a997aa
Merge remote-tracking branch 'origin/master' into idtoken-cloudrun
May 16, 2021
58f0c48
comments addressed
TimurSadykov May 18, 2021
9b2b10d
Merge branch 'master' into idtoken-cloudrun
TimurSadykov May 18, 2021
308670d
Merge remote-tracking branch 'origin/master' into idtoken-cloudrun
TimurSadykov May 20, 2021
ded1cb9
Merge remote-tracking branch 'origin/master' into idtoken-cloudrun
TimurSadykov May 24, 2021
85114c4
remove redundant idtoken refresh
TimurSadykov May 24, 2021
5ab8df6
fix of removing redundant idtoken referesh
TimurSadykov May 25, 2021
5dc530e
fix tests
TimurSadykov May 25, 2021
903058c
Merge branch 'idtoken-cloudrun' of https://github.com/googleapis/goog…
TimurSadykov May 25, 2021
cf6cbb2
null check and more docs
TimurSadykov May 26, 2021
9877f93
Merge remote-tracking branch 'origin/master' into idtoken-cloudrun
TimurSadykov May 26, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -722,6 +722,8 @@ public void IdTokenCredentials_WithUserEmailScope_success() throws IOException {
IdTokenCredentials tokenCredential =
IdTokenCredentials.newBuilder().setIdTokenProvider(credentials).build();

tokenCredential.getRequestMetadata();
TimurSadykov marked this conversation as resolved.
Show resolved Hide resolved

// UserCredential returns access token until refresh,
// IDTokenCredential does refresh during instantiation
assertEquals(DEFAULT_ID_TOKEN, tokenCredential.getAccessToken().getTokenValue());
Expand Down