New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace non-precondition use of Preconditions #539

Merged

elharo merged 3 commits into master from i510

Jan 14, 2021

Contributor

elharo commented Jan 13, 2021 •

edited by chingor13

fixes #510


          replace non-precondition use of Preconditions

df35387

elharo requested a review from chingor13

January 13, 2021 16:53

elharo requested a review from a team as a code owner

January 13, 2021 16:53

google-cla bot added the cla: yes label


          format

cd9274e

codecov bot commented Jan 13, 2021 •

edited

Codecov Report

Merging #539 (45e71b0) into master (75d85b3) will decrease coverage by 0.25%.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##             master     #539      +/-   ##
============================================
- Coverage     80.13%   79.87%   -0.26%     
  Complexity      424      424              
============================================
  Files            28       28              
  Lines          1978     1983       +5     
  Branches        212      215       +3     
============================================
- Hits           1585     1584       -1     
- Misses          283      286       +3     
- Partials        110      113       +3

Impacted Files	Coverage Δ	Complexity Δ
...java/com/google/auth/oauth2/OAuth2Credentials.java	`82.85% <40.00%> (-5.15%)`	`38.00 <0.00> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75d85b3...45e71b0. Read the comment docs.

elharo changed the title ~~replace non-precondition use of Preconditions~~ fix: replace non-precondition use of Preconditions

elharo added the type: cleanup label

chingor13 approved these changes

View reviewed changes


          Merge branch 'master' into i510

45e71b0

elharo merged commit f2ab4f1 into master

elharo deleted the i510 branch

January 14, 2021 19:59

gcf-merge-on-green bot pushed a commit that referenced this pull request


          chore: release 0.23.0 (#525)

c76766e

🤖 I have created a release \*beep\* \*boop\* 
---
## [0.23.0](https://www.github.com/googleapis/google-auth-library-java/compare/v0.22.2...v0.23.0) (2021-01-26)


### ⚠ BREAKING CHANGES

* privatize deprecated constructor (#473)

### Features

* allow custom lifespan for impersonated creds ([#515](https://www.github.com/googleapis/google-auth-library-java/issues/515)) ([0707ed4](https://www.github.com/googleapis/google-auth-library-java/commit/0707ed4bbb40fb775f196004ee30f8c695fe662b))
* allow custom scopes for compute engine creds ([#514](https://www.github.com/googleapis/google-auth-library-java/issues/514)) ([edc8d6e](https://www.github.com/googleapis/google-auth-library-java/commit/edc8d6e0e7ca2c6749d026ba42854a09c4879fd6))
* allow set lifetime for service account creds ([#516](https://www.github.com/googleapis/google-auth-library-java/issues/516)) ([427f2d5](https://www.github.com/googleapis/google-auth-library-java/commit/427f2d5610f0e8184a21b24531d2549a68c0b546))
* promote IdToken and JWT features ([#538](https://www.github.com/googleapis/google-auth-library-java/issues/538)) ([b514fe0](https://www.github.com/googleapis/google-auth-library-java/commit/b514fe0cebe5a294e0cf97b7b5349e6a523dc7b2))


### Bug Fixes

* per google style, logger is lower case ([#529](https://www.github.com/googleapis/google-auth-library-java/issues/529)) ([ecfc6a2](https://www.github.com/googleapis/google-auth-library-java/commit/ecfc6a2ea6060e06629b5d422b23b842b917f55e))
* privatize deprecated constructor ([#473](https://www.github.com/googleapis/google-auth-library-java/issues/473)) ([5804ff0](https://www.github.com/googleapis/google-auth-library-java/commit/5804ff03a531268831ac797ab262638a3119c14f))
* remove deprecated methods ([#537](https://www.github.com/googleapis/google-auth-library-java/issues/537)) ([427963e](https://www.github.com/googleapis/google-auth-library-java/commit/427963e04702d8b73eca5ed555539b11bbe97342))
* replace non-precondition use of Preconditions ([#539](https://www.github.com/googleapis/google-auth-library-java/issues/539)) ([f2ab4f1](https://www.github.com/googleapis/google-auth-library-java/commit/f2ab4f14262d54de0fde85494cfd92cf01a30cbe))
* switch to GSON ([#531](https://www.github.com/googleapis/google-auth-library-java/issues/531)) ([1b98d5c](https://www.github.com/googleapis/google-auth-library-java/commit/1b98d5c86fc5e56187c977e7f43c39bb62483d40))
* use default timeout if given 0 for ImpersonatedCredentials ([#527](https://www.github.com/googleapis/google-auth-library-java/issues/527)) ([ec74870](https://www.github.com/googleapis/google-auth-library-java/commit/ec74870c372a33d4157b45bb5d59ad7464fb2238))


### Dependencies

* update dependency com.google.appengine:appengine-api-1.0-sdk to v1.9.84 ([#422](https://www.github.com/googleapis/google-auth-library-java/issues/422)) ([b262c45](https://www.github.com/googleapis/google-auth-library-java/commit/b262c4587b058e6837429ee05f1b6a63620ee598))
* update dependency com.google.guava:guava to v30.1-android ([#522](https://www.github.com/googleapis/google-auth-library-java/issues/522)) ([4090d1c](https://www.github.com/googleapis/google-auth-library-java/commit/4090d1cb50041bceb1cd975d1a9249a412df936f))


### Documentation

* fix wording in jwtWithClaims Javadoc ([#536](https://www.github.com/googleapis/google-auth-library-java/issues/536)) ([af21727](https://www.github.com/googleapis/google-auth-library-java/commit/af21727815263fb5ffc07ede953cf042fac3ac2b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

release-please bot mentioned this pull request

chore(main): release google-auth-library-java 1.0.0 #819

Closed

release-please bot mentioned this pull request

chore(main): release 1.11.0 #974

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment