Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Automatic-Module-Name to manifest #324 #325

Closed
wants to merge 1 commit into from
Closed

fix: Add Automatic-Module-Name to manifest #324 #325

wants to merge 1 commit into from

Conversation

man0s
Copy link
Contributor

@man0s man0s commented Aug 9, 2019

Fixes #324

@man0s man0s requested a review from a team as a code owner August 9, 2019 11:12
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 9, 2019
@man0s
Copy link
Contributor Author

man0s commented Aug 9, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 9, 2019
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to go in individual the submodules, not the parent pom. And looking at that now we have split packages there we have to resolve first. Ick.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On further investigation, I don't think the packages are split; so it is possible to do this now but it does need to be in the submodules, not the parent.

@man0s
Copy link
Contributor Author

man0s commented Aug 9, 2019

@elharo I see, I will update it sortly. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Automatic-Module-Name to manifest
3 participants