Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer Credential building in HttpCredentialsAdapter until request time #223

Closed
wants to merge 4 commits into from
Closed

Defer Credential building in HttpCredentialsAdapter until request time #223

wants to merge 4 commits into from

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jan 16, 2019

Fixes #119

Note that this is a slight behavioral change that delays fetching the request metadata (fetch credentials) until right before the request is executing using a HttpExecuteInterceptor. If the user has already configured an interceptor, we run theirs before fetching credentials.

@chingor13 chingor13 requested a review from a team as a code owner January 16, 2019 23:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2019
@chingor13 chingor13 mentioned this pull request Jan 17, 2019
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Feb 7, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Feb 7, 2019
@sduskis sduskis added status: blocked Resolving the issue is dependent on other work. and removed 🚨 This issue needs some love. labels Feb 13, 2019
@chingor13 chingor13 changed the title WIP: Set audience URI from request URI for ServiceAccountJwtAccessCredentials Defer Credential building in HttpCredentialsAdapter until request time Jul 15, 2019
@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ee67b5d). Click here to learn what that means.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #223   +/-   ##
=========================================
  Coverage          ?   78.77%           
  Complexity        ?      338           
=========================================
  Files             ?       21           
  Lines             ?     1498           
  Branches          ?      163           
=========================================
  Hits              ?     1180           
  Misses            ?      238           
  Partials          ?       80
Impacted Files Coverage Δ Complexity Δ
...a/com/google/auth/http/HttpCredentialsAdapter.java 67.39% <81.25%> (ø) 6 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee67b5d...1823e98. Read the comment docs.

@chingor13
Copy link
Contributor Author

This shouldn't actually be necessary with the explicit credentials building from #290

@chingor13 chingor13 closed this Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. status: blocked Resolving the issue is dependent on other work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audience URI?
5 participants