Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: makes exceptions public so others can import and handle them #1124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

julianSelser
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1122 #1123 ☕️

Makes exception public for clients of the library to import and handle them.

@julianSelser julianSelser requested a review from a team as a code owner January 6, 2023 16:01
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 6, 2023
@julianSelser julianSelser force-pushed the make_exceptions_public_for_importing branch from c243e21 to 22c7aac Compare January 6, 2023 16:55
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@julianSelser julianSelser force-pushed the make_exceptions_public_for_importing branch from 22c7aac to 2f4a171 Compare January 6, 2023 16:57
@julianSelser julianSelser changed the title Makes exceptions public so others can import and handle them fix: makes exceptions public so others can import and handle them Jan 6, 2023
@TimurSadykov
Copy link
Member

Thanks for contributing! Exceptions are package private by design, but you can catch them using interfaces. More details in the issue.

Feel free to change this PR into OAuth2Error implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making GoogleAuthException public
2 participants