feat: add support for reading apiVersion in discovery artifacts #2380
+33
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
force-pushed
the
add-support-for-api-versioning
branch
from
38b97cb
to
8eaa3e8
Compare
parthea
force-pushed
the
add-support-for-api-versioning
branch
from
8eaa3e8
to
90cd12d
Compare
parthea
commented
Apr 10, 2024
Comment on lines
+45
to
+46
| "google-api-core[grpc] @ git+https://github.com/googleapis/python-api-core.git@add-api-version-header", | ||
| #"google-api-core >= 1.31.5, <3.0.0.dev0,!=2.0.*,!=2.1.*,!=2.2.*,!=2.3.0", |
There was a problem hiding this comment.
For prototyping purposes only, revert once googleapis/python-api-core#638 is merged and released to PyPI
| @@ -2,5 +2,4 @@ | |||
| httplib2==0.19.0 | |||
| google-auth==1.32.0 | |||
| google-auth-httplib2==0.2.0 | |||
| google-api-core | |||
There was a problem hiding this comment.
For prototyping purposes only, revert once googleapis/python-api-core#638 is merged and released to PyPI
| @@ -9,5 +9,4 @@ | |||
| httplib2==0.19.0 | |||
| google-auth==1.32.0 | |||
| google-auth-httplib2==0.2.0 | |||
| google-api-core==1.31.5 | |||
There was a problem hiding this comment.
For prototyping purposes only, revert once googleapis/python-api-core#638 is merged and released to PyPI
| @@ -2,5 +2,4 @@ | |||
| httplib2==0.19.0 | |||
| google-auth | |||
| google-auth-httplib2==0.2.0 | |||
| google-api-core==1.31.5 | |||
There was a problem hiding this comment.
For prototyping purposes only, revert once googleapis/python-api-core#638 is merged and released to PyPI
| @@ -3,5 +3,4 @@ | |||
| httplib2==0.19.0 | |||
| google-auth | |||
| google-auth-httplib2==0.2.0 | |||
| google-api-core==2.15.0 | |||
There was a problem hiding this comment.
For prototyping purposes only, revert once googleapis/python-api-core#638 is merged and released to PyPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards b/330986358