Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handling for partial downlads #2310

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

coanghel
Copy link

@coanghel coanghel commented Jan 4, 2024

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass Used nox -s scripts-3.9 , also manually ran test_http.py
  • Code coverage does not decrease (if any source code was changed) No change before/after with scripts-3.9
  • Appropriate docs were updated (if necessary)

Added an optional start parameter to the constructor of MediaIoBaseDownload() to allow for resuming a download from a certain byte. If not provided, MediaIoBaseDownload() will continue to function as it does currently and start the download from byte 0.

Fixes #2309 🦕

@coanghel coanghel requested a review from a team as a code owner January 4, 2024 20:34
Copy link

google-cla bot commented Jan 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 4, 2024
@coanghel coanghel changed the title Added handling for partial downlads to MediaIoBaseDownload() feat: handling for partial downlads to MediaIoBaseDownload class Jan 4, 2024
Copy link

conventional-commit-lint-gcf bot commented Jan 4, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@coanghel coanghel changed the title feat: handling for partial downlads to MediaIoBaseDownload class feat: handling for partial downlads Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MediaIoBaseDownload Cannot Handle Resuming Partial Download
2 participants