Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MediaIoBaseDownload range header off-by-one #1595

Merged

Commits on Nov 9, 2021

  1. fix: MediaIoBaseDownload range header off-by-one

    Issue: It looks like Range header end value was constructed by adding chunk size to
    current position. This leads into the request being one byte longer, and also
    the received response body is one byte longer than anticipated.
    
    Fix: adjust the end to be one byte earlier.
    
    For example with `chunksize=1024` and current position being 0, the range header
    should be set to `bytes=0-1023`.
    
    See: https://httpwg.org/specs/rfc7233.html#rule.ranges-specifier
    
    Resolves: googleapis#1593
    jvtm committed Nov 9, 2021
    Copy the full SHA
    d9777dc View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Copy the full SHA
    96a5d08 View commit details
    Browse the repository at this point in the history