New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve issue where certain artifacts would not be updated #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
May 27, 2021
parthea
changed the title
fix: resolve issue where certain static artifacts would not be updated.
fix: resolve issue where certain artifacts would not be updated.
May 27, 2021
parthea
changed the title
fix: resolve issue where certain artifacts would not be updated.
fix: resolve issue where certain artifacts would not be updated
May 27, 2021
parthea
force-pushed
the
fix-static-artifact-versioning
branch
from
May 27, 2021 14:15
195a77e
to
c60fbd6
Compare
busunkim96
suggested changes
May 27, 2021
@busunkim96 PTAL |
busunkim96
approved these changes
May 27, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 1, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.7.0](https://www.github.com/googleapis/google-api-python-client/compare/v2.6.0...v2.7.0) (2021-06-01) ### Features * **adexchangebuyer:** update the api 3cf7a8d ([ab1d6dc](https://www.github.com/googleapis/google-api-python-client/commit/ab1d6dc365fc482d482de197da7f7583afd04bd0)) * **admin:** update the api 7bac81f ([ab1d6dc](https://www.github.com/googleapis/google-api-python-client/commit/ab1d6dc365fc482d482de197da7f7583afd04bd0)) * **androidmanagement:** update the api 8779902 ([bdce941](https://www.github.com/googleapis/google-api-python-client/commit/bdce9419ca05d20e0eecd817f404f292a56ce79c)) * **apigee:** update the api 37f3142 ([4c9ccb0](https://www.github.com/googleapis/google-api-python-client/commit/4c9ccb08aa866b5402c5e63c70306b5a3c121ba1)) * **bigquery:** update the api 086d714 ([508c39f](https://www.github.com/googleapis/google-api-python-client/commit/508c39fa665c901d9d754aa31dc9d1af45469ec4)) * **container:** update the api 514acdb ([4c9ccb0](https://www.github.com/googleapis/google-api-python-client/commit/4c9ccb08aa866b5402c5e63c70306b5a3c121ba1)) * **content:** update the api aab557d ([ab1d6dc](https://www.github.com/googleapis/google-api-python-client/commit/ab1d6dc365fc482d482de197da7f7583afd04bd0)) * **content:** update the api eaf742d ([bdce941](https://www.github.com/googleapis/google-api-python-client/commit/bdce9419ca05d20e0eecd817f404f292a56ce79c)) * **dataflow:** update the api d979251 ([38664e8](https://www.github.com/googleapis/google-api-python-client/commit/38664e8dec117413b8d27fc7230eb9c351d2c0de)) * **dfareporting:** update the api c83912b ([ab1d6dc](https://www.github.com/googleapis/google-api-python-client/commit/ab1d6dc365fc482d482de197da7f7583afd04bd0)) * **dlp:** update the api 7e3d1c4 ([4c9ccb0](https://www.github.com/googleapis/google-api-python-client/commit/4c9ccb08aa866b5402c5e63c70306b5a3c121ba1)) * **documentai:** update the api 222030d ([4c9ccb0](https://www.github.com/googleapis/google-api-python-client/commit/4c9ccb08aa866b5402c5e63c70306b5a3c121ba1)) * **doubleclickbidmanager:** update the api 895ff46 ([ab1d6dc](https://www.github.com/googleapis/google-api-python-client/commit/ab1d6dc365fc482d482de197da7f7583afd04bd0)) * **firebase:** update the api 6bd0412 ([4c9ccb0](https://www.github.com/googleapis/google-api-python-client/commit/4c9ccb08aa866b5402c5e63c70306b5a3c121ba1)) * **ondemandscanning:** update the api b77d12d ([4c9ccb0](https://www.github.com/googleapis/google-api-python-client/commit/4c9ccb08aa866b5402c5e63c70306b5a3c121ba1)) * **osconfig:** update the api c541143 ([4c9ccb0](https://www.github.com/googleapis/google-api-python-client/commit/4c9ccb08aa866b5402c5e63c70306b5a3c121ba1)) * **prod_tt_sasportal:** update the api 1e0f4a6 ([4c9ccb0](https://www.github.com/googleapis/google-api-python-client/commit/4c9ccb08aa866b5402c5e63c70306b5a3c121ba1)) * **redis:** update the api 4350b35 ([38664e8](https://www.github.com/googleapis/google-api-python-client/commit/38664e8dec117413b8d27fc7230eb9c351d2c0de)) * **serviceconsumermanagement:** update the api e204636 ([4c9ccb0](https://www.github.com/googleapis/google-api-python-client/commit/4c9ccb08aa866b5402c5e63c70306b5a3c121ba1)) * **servicecontrol:** update the api facd7ec ([ab1d6dc](https://www.github.com/googleapis/google-api-python-client/commit/ab1d6dc365fc482d482de197da7f7583afd04bd0)) * **serviceusage:** update the api b79b21e ([4c9ccb0](https://www.github.com/googleapis/google-api-python-client/commit/4c9ccb08aa866b5402c5e63c70306b5a3c121ba1)) * **sqladmin:** update the api f2bb5e6 ([a940762](https://www.github.com/googleapis/google-api-python-client/commit/a9407624e954e34bfd989f64ed0f5be74c40d4c5)) ### Bug Fixes * resolve issue where certain artifacts would not be updated ([#1385](https://www.github.com/googleapis/google-api-python-client/issues/1385)) ([31bbe51](https://www.github.com/googleapis/google-api-python-client/commit/31bbe51739f966491f1be8ab67c500c65c049daf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1384
This PR is also a partial fix for #1330 where there are duplicate discovery artifacts for the same API and version. The issue is that in
describe.py
there is a call tosafe_version()
which is changing the version to remove decimal places.For example, the following artifacts exist
https://github.com/googleapis/google-api-python-client/blob/master/googleapiclient/discovery_cache/documents/adexchangebuyer.v1.2.json
https://github.com/googleapis/google-api-python-client/blob/master/googleapiclient/discovery_cache/documents/adexchangebuyer.v12.json
For
adexchangebuyer
versionv.1.2
, instead of thiswe would have this.
This PR fixes the versioning issue. The reason that this is a partial fix for #1330 is that another PR is needed to actually delete the duplicated discovery artifacts.
To validate this change, run updatediscoveryartifacts.py locally and you should see
adexchangebuyer.v1.2.json
updated.Once this is merged, I'll trigger the GitHub action that updates discovery artifacts. This PR should not be a breaking change as it won't result in deleting discovery artifacts.