Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: discovery supports retries #967

Merged
merged 1 commit into from Jul 15, 2020

Conversation

DFrenkel
Copy link
Contributor

Adding ability for discovery to retry on eligible http errors
and connection problems with randomized exponential backoff.

Also:

  • DRYing discovery tests to avoid warnings when reading test data.
  • Updating .gitignore

Fixes: #848

Adding ability for discovery to retry on eligible http errors
and connection problems with randomized exponential backoff.

Also:
 * DRYing discovery tests to avoid warnings when reading test data.
 * Updating .gitignore

Fixes: googleapis#848
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2020
@busunkim96 busunkim96 self-requested a review July 15, 2020 19:59
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DFrenkel!

@busunkim96 busunkim96 merged commit f3348f9 into googleapis:master Jul 15, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 15, 2020
@DFrenkel DFrenkel deleted the discovery-retry branch July 15, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch Discovery Document doesn't support retry mechanism
5 participants