Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: generate homegraph api #1807

Closed
wants to merge 1 commit into from
Closed

Conversation

proppy
Copy link
Contributor

@proppy proppy commented Aug 30, 2019

  • run the generate
  • clean up the diff to only include homegraph changes

Let me know if you'd prefer to update all the generate API as part of the bigger CL instead.

Fixes #1806

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

- run the generate
- clean up the diff to only include homegraph changes
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2019
@bcoe
Copy link
Contributor

bcoe commented Sep 5, 2019

@proppy awesome, thank you for the contribution (and ignore my comments on #1806).

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple nits, but this is looking pretty solid.


import {
AuthPlus,
getAPI,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the linting looks a bit weird, i think you might need to run:

npm run fix

To fix the linting.

"devDependencies": {
"gts": "^1.0.0",
"null-loader": "^3.0.0",
"ts-loader": "^6.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe that the generator generates with up-to-date dependencies, so you might want to update these accordingly.

@bcoe
Copy link
Contributor

bcoe commented Sep 6, 2019

Closing in favor of #1814, @JustinBeckwith just ran the whole generator.

We'll make an effort to have this released for you shortly.

@bcoe bcoe closed this Sep 6, 2019
@proppy
Copy link
Contributor Author

proppy commented Sep 9, 2019

@bcoe Thanks! and sorry for the lag ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate binding for the homegraph api
5 participants