Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: remove unnecessary commons-logging transitive dependency #2424

Closed
wants to merge 1 commit into from
Closed

deps: remove unnecessary commons-logging transitive dependency #2424

wants to merge 1 commit into from

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jan 29, 2024 •
edited

Fixes #2423

Ensure the checks pass before merge.

=> It turned out the classes from commons-logging are actually used indirectly in this library.

[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s -- in com.google.api.client.googleapis.MethodOverrideTest
[INFO] 
[INFO] Results:
[INFO] 
Error:  Errors: 
Error:    GoogleApacheHttpTransportTest.socketFactoryRegistryHandlerTest:38 » NoClassDefFound org/apache/commons/logging/LogFactory
Error:    GoogleApacheHttpTransportTest>MtlsTransportBaseTest.testNoCertificate:100->buildTrustedTransport:32 » NoClassDefFound Could not initialize class org.apache.http.conn.ssl.SSLConnectionSocketFactory
Error:    GoogleApacheHttpTransportTest>MtlsTransportBaseTest.testNotUseCertificate:82->buildTrustedTransport:32 » NoClassDefFound Could not initialize class org.apache.http.conn.ssl.SSLConnectionSocketFactory
Error:    GoogleApacheHttpTransportTest>MtlsTransportBaseTest.testUseProvidedCertificate:91->buildTrustedTransport:32 » NoClassDefFound Could not initialize class org.apache.http.conn.ssl.SSLConnectionSocketFactory

@suztomo suztomo requested a review from a team as a code owner January 29, 2024 15:31
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 29, 2024
@suztomo suztomo closed this Jan 29, 2024
@suztomo suztomo mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try removing commons-logging dependency
1 participant
@suztomo