New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update GoogleJsonError object to accomodate all fields in Invalid parameter exception #1783
Conversation
…d parameter exception
} | ||
|
||
public List<ParameterViolations> getParameterViolations() { | ||
return parameterViolations; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exposes mutable private state, needs a defensive copy
return parameterViolations; | ||
} | ||
|
||
public void setParameterViolations(List<ParameterViolations> parameterViolations) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exposes mutable private state
return details; | ||
} | ||
|
||
public void setDetails(List<Details> details) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exposes mutable private state
@@ -246,6 +302,14 @@ public final void setMessage(String message) { | |||
this.message = message; | |||
} | |||
|
|||
public List<Details> getDetails() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exposes mutable private state
🤖 I have created a release \*beep\* \*boop\* --- ### [1.31.5](https://www.github.com/googleapis/google-api-java-client/compare/v1.31.4...v1.31.5) (2021-05-10) ### Bug Fixes * release scripts from issuing overlapping phases ([#1769](https://www.github.com/googleapis/google-api-java-client/issues/1769)) ([3174ff9](https://www.github.com/googleapis/google-api-java-client/commit/3174ff9ddf0c7428b90bff766c6b18bf17d1feac)) * remove deprecated parent pom ([#1785](https://www.github.com/googleapis/google-api-java-client/issues/1785)) ([5da3355](https://www.github.com/googleapis/google-api-java-client/commit/5da335518ff5076ea5dd4f40fd0494330458296c)) * update GoogleJsonError object to accomodate all fields in Invalid parameter exception ([#1783](https://www.github.com/googleapis/google-api-java-client/issues/1783)) ([94c4570](https://www.github.com/googleapis/google-api-java-client/commit/94c4570e16324b4c654d4ec3f0f940926064d955)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Fixes b/185405327
Invalid parameter error message does not contain details about which parameter is the invalid one. These fields have been added to GoogleJsonError object.