Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup checkstyle import rules #1503

Merged
merged 2 commits into from Mar 13, 2020
Merged

fix: cleanup checkstyle import rules #1503

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24aa6ce
fix: format warnings at head
suraj-qlogic Mar 9, 2020
8792f59
fix: update checkstyle rule for static import
suraj-qlogic Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 0 additions & 10 deletions checkstyle.xml
View file
Open in desktop
Expand Up @@ -52,16 +52,6 @@ page at http://checkstyle.sourceforge.net/config.html -->
<property name="severity" value="error"/>
</module>

<module name="ImportOrder">
suraj-qlogic marked this conversation as resolved.
Show resolved Hide resolved
<!-- Checks for out of order import statements. -->

<property name="severity" value="warning"/>
<property name="groups" value="com.google,android,junit,net,org,java,javax"/>
suraj-qlogic marked this conversation as resolved.
Show resolved Hide resolved
<!-- This ensures that static imports go first. -->
<property name="option" value="top"/>
<property name="tokens" value="STATIC_IMPORT, IMPORT"/>
</module>

<!--
JAVADOC CHECKS
Expand Down
4 changes: 3 additions & 1 deletion ...pi/client/googleapis/extensions/appengine/testing/auth/oauth2/MockAppIdentityService.java
View file
Open in desktop
Expand Up @@ -91,5 +91,7 @@ public ParsedAppId parseFullAppId(String fullAppId) {
}

@Override
public String getDefaultGcsBucketName() { return null; }
public String getDefaultGcsBucketName() {
return null;
}
}
2 changes: 1 addition & 1 deletion ...n/java/com/google/api/client/googleapis/testing/auth/oauth2/MockTokenServerTransport.java
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@
*/
@Beta
public class MockTokenServerTransport extends MockHttpTransport {
/** Old URL of Google's token server (for backwards compatibility) */
/** Old URL of Google's token server (for backwards compatibility). */
private static final String LEGACY_TOKEN_SERVER_URL =
"https://accounts.google.com/o/oauth2/token";

Expand Down