Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user-agent should use identifier/version #1425

Merged
merged 2 commits into from Nov 21, 2019
Merged

fix: user-agent should use identifier/version #1425

merged 2 commits into from Nov 21, 2019

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Nov 20, 2019 •
edited

Fixes #1426

@chingor13 chingor13 requested a review from a team as a code owner November 20, 2019 18:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 20, 2019
codyoss
codyoss approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, does this fix an open issue?

@elharo elharo mentioned this pull request Nov 20, 2019
Closed
@chingor13 chingor13 merged commit bfb4d9c into googleapis:master Nov 21, 2019
@chingor13 chingor13 deleted the fix-user-agent branch November 21, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User-Agent string uses invalid format
4 participants
@chingor13 @elharo @codyoss @googlebot