Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details to GoogleJsonResponseExceptions created with GoogleJsonResponseExceptionFactoryTesting #1395

Merged
merged 2 commits into from Oct 21, 2019
Merged

Add details to GoogleJsonResponseExceptions created with GoogleJsonResponseExceptionFactoryTesting #1395

merged 2 commits into from Oct 21, 2019

Conversation

SUPERCILEX
Copy link
Contributor

Currently, GoogleJsonResponseExceptions created with GoogleJsonResponseExceptionFactoryTesting will have null #getDetails().

@SUPERCILEX SUPERCILEX requested a review from a team as a code owner October 20, 2019 22:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2019
@chingor13 chingor13 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 21, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 21, 2019
chingor13
chingor13 requested changes Oct 21, 2019
View reviewed changes
Copy link
Collaborator

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this.

...com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java Show resolved Hide resolved
@chingor13 chingor13 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 21, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 21, 2019
@chingor13 chingor13 merged commit 1ffdba6 into googleapis:master Oct 21, 2019
@SUPERCILEX
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SUPERCILEX @chingor13 @googlebot @kokoro-team