Skip to content

Commit ce22c0e

Browse files
authored
fix: cleanup checkstyle import rules (#1503)
* fix: format warnings at head * fix: update checkstyle rule for static import
1 parent 6c8dbb3 commit ce22c0e

File tree

50 files changed

+6
-57
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+6
-57
lines changed

checkstyle.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,11 @@ page at http://checkstyle.sourceforge.net/config.html -->
5353
</module>
5454

5555
<module name="ImportOrder">
56-
<!-- Checks for out of order import statements. -->
57-
5856
<property name="severity" value="warning"/>
59-
<property name="groups" value="com.google,android,junit,net,org,java,javax"/>
6057
<!-- This ensures that static imports go first. -->
6158
<property name="option" value="top"/>
59+
<property name="separatedStaticGroups" value="true"/>
60+
<property name="caseSensitive" value="true"/>
6261
<property name="tokens" value="STATIC_IMPORT, IMPORT"/>
6362
</module>
6463

google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAuthIOException.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import com.google.android.gms.auth.GoogleAuthException;
1616
import com.google.api.client.util.Beta;
1717
import com.google.api.client.util.Preconditions;
18-
1918
import java.io.IOException;
2019

2120
/**

google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import com.google.appengine.api.appidentity.AppIdentityService;
2828
import com.google.appengine.api.appidentity.AppIdentityService.GetAccessTokenResult;
2929
import com.google.appengine.api.appidentity.AppIdentityServiceFactory;
30-
3130
import java.io.IOException;
3231
import java.util.Collection;
3332
import java.util.Collections;

google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/notifications/AppEngineNotificationServlet.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@
1818
import com.google.api.client.googleapis.extensions.servlet.notifications.WebhookUtils;
1919
import com.google.api.client.util.Beta;
2020
import com.google.api.client.util.store.DataStoreFactory;
21-
2221
import java.io.IOException;
23-
2422
import javax.servlet.ServletException;
2523
import javax.servlet.http.HttpServlet;
2624
import javax.servlet.http.HttpServletRequest;

google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/testing/auth/oauth2/MockAppIdentityService.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import com.google.appengine.api.appidentity.AppIdentityService;
1919
import com.google.appengine.api.appidentity.AppIdentityServiceFailureException;
2020
import com.google.appengine.api.appidentity.PublicCertificate;
21-
2221
import java.util.Collection;
2322
import java.util.Date;
2423

@@ -91,5 +90,7 @@ public ParsedAppId parseFullAppId(String fullAppId) {
9190
}
9291

9392
@Override
94-
public String getDefaultGcsBucketName() { return null; }
93+
public String getDefaultGcsBucketName() {
94+
return null;
95+
}
9596
}

google-api-client-java6/src/main/java/com/google/api/client/googleapis/extensions/java6/auth/oauth2/GooglePromptReceiver.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
import com.google.api.client.extensions.java6.auth.oauth2.AbstractPromptReceiver;
1818
import com.google.api.client.googleapis.auth.oauth2.GoogleOAuthConstants;
19-
2019
import java.io.IOException;
2120

2221
/**

google-api-client-protobuf/src/main/java/com/google/api/client/googleapis/services/protobuf/AbstractGoogleProtoClientRequest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import com.google.api.client.http.protobuf.ProtoHttpContent;
2323
import com.google.api.client.util.Beta;
2424
import com.google.protobuf.MessageLite;
25-
2625
import java.io.IOException;
2726

2827
/**

google-api-client-protobuf/src/main/java/com/google/api/client/googleapis/services/protobuf/CommonGoogleProtoClientRequestInitializer.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import com.google.api.client.googleapis.services.AbstractGoogleClientRequest;
1818
import com.google.api.client.googleapis.services.CommonGoogleClientRequestInitializer;
1919
import com.google.api.client.util.Beta;
20-
2120
import java.io.IOException;
2221

2322
/**

google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/notifications/NotificationServlet.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@
1919
import com.google.api.client.util.store.DataStore;
2020
import com.google.api.client.util.store.DataStoreFactory;
2121
import com.google.api.client.util.store.MemoryDataStoreFactory;
22-
2322
import java.io.IOException;
24-
2523
import javax.servlet.ServletException;
2624
import javax.servlet.http.HttpServlet;
2725
import javax.servlet.http.HttpServletRequest;

google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/notifications/WebhookUtils.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,11 @@
2323
import com.google.api.client.util.StringUtils;
2424
import com.google.api.client.util.store.DataStore;
2525
import com.google.api.client.util.store.DataStoreFactory;
26-
2726
import java.io.IOException;
2827
import java.io.InputStream;
2928
import java.util.Enumeration;
3029
import java.util.logging.Level;
3130
import java.util.logging.Logger;
32-
3331
import javax.servlet.ServletException;
3432
import javax.servlet.http.HttpServlet;
3533
import javax.servlet.http.HttpServletRequest;

0 commit comments

Comments
 (0)