Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport/bytestream): Add Close method for shutdown #787

Merged
merged 2 commits into from Jan 11, 2021
Merged

feat(transport/bytestream): Add Close method for shutdown #787

merged 2 commits into from Jan 11, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Dec 11, 2020

This pacakge is still labeled expirmental. At some point we should
decide if we want to keep supporting it or deprecate and remove.

Fixes: #775

This pacakge is still labeled expirmental. At some point we should
decide if we want to keep supporting it or deprecate and remove.

Fixes: #775
@codyoss codyoss requested review from yoshi-approver and a team as code owners December 11, 2020 15:34
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2020
@codyoss
Copy link
Member Author

codyoss commented Dec 11, 2020

Ran go test -run TestClientWrite_AfterSetupClose -count 10000 after change and all passed locally.

@codyoss
Copy link
Member Author

codyoss commented Jan 11, 2021

@tbpg Could you take a quick look at this when you have a chance.

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Jan 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 96bfd87 into googleapis:master Jan 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 11, 2021
@codyoss codyoss deleted the bytestream branch January 11, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transport/bytestream: TestClientWrite_CloseAndRecvFails is flaky
2 participants