Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(all): use CheckResponse for media downloads #773

Merged
merged 4 commits into from Dec 11, 2020
Merged

fix(all): use CheckResponse for media downloads #773

merged 4 commits into from Dec 11, 2020

Commits on Dec 7, 2020

  1. fix(all): use CheckResponse for media downloads 

    If a method supports media downloads use CheckResponse. This method
provided extra context to errors if the api follow
https://google.aip.dev/193. The storage api will continue to use
CheckMediaResponse as it does not conform to the aip due to legacy
reasons.

Fixes: #752
    @codyoss
    codyoss committed Dec 7, 2020
    Copy the full SHA
    e96d3f1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into check-response

    @codyoss
    codyoss committed Dec 7, 2020
    Copy the full SHA
    3dd4a72 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Merge branch 'master' into check-response

    @codyoss
    codyoss committed Dec 8, 2020
    Copy the full SHA
    4069e3c View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Merge branch 'master' into check-response

    @codyoss
    codyoss committed Dec 11, 2020
    Copy the full SHA
    baeefbd View commit details
    Browse the repository at this point in the history