Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split large compute file up #2546

Merged
merged 7 commits into from Apr 30, 2024

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Apr 25, 2024

This is a followup to #2544. That change reduced the size of the compute client from 9.4M to 6.7. This change now splits the compute client into three files ranging from 2.7-1.8M each. This should allow editors and tooling to better be able to process the client.

This is a followup to googleapis#2544. That change reduced the size of
the compute client from 9.4M to 6.7. This change now splits the
compute client into three files ranging from 2.7-1.8M each. This
should allow editors and tooling to better be able to process the
client.
@codyoss codyoss marked this pull request as ready for review April 26, 2024 14:37
@codyoss codyoss requested review from yoshi-approver and a team as code owners April 26, 2024 14:37
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Apr 26, 2024
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 26, 2024
@codyoss codyoss requested a review from quartzmo April 29, 2024 16:35
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2024
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2024
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really really cool.

google-api-go-generator/gen.go Outdated Show resolved Hide resolved
google-api-go-generator/gen.go Outdated Show resolved Hide resolved
google-api-go-generator/gen.go Outdated Show resolved Hide resolved
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Apr 30, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1b6db6c into googleapis:main Apr 30, 2024
5 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 30, 2024
@codyoss codyoss deleted the compute-split branch April 30, 2024 17:06
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 30, 2024
🤖 I have created a release *beep* *boop*
---


## [0.177.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.176.1...v0.177.0) (2024-04-30)


### Features

* **all:** Auto-regenerate discovery clients ([#2548](https://togithub.com/googleapis/google-api-go-client/issues/2548)) ([32a5d10](https://togithub.com/googleapis/google-api-go-client/commit/32a5d10b1870bacb93fdf065e5ce7923c04039e8))
* **all:** Auto-regenerate discovery clients ([#2550](https://togithub.com/googleapis/google-api-go-client/issues/2550)) ([f9bf96d](https://togithub.com/googleapis/google-api-go-client/commit/f9bf96df3a9a7ee9eb5b4b01c60d50f4c70e45c9))
* **all:** Auto-regenerate discovery clients ([#2551](https://togithub.com/googleapis/google-api-go-client/issues/2551)) ([4418f5f](https://togithub.com/googleapis/google-api-go-client/commit/4418f5fc551ce9a1edda277ddf483f3dd596d9aa))
* **all:** Auto-regenerate discovery clients ([#2553](https://togithub.com/googleapis/google-api-go-client/issues/2553)) ([2f46e14](https://togithub.com/googleapis/google-api-go-client/commit/2f46e14ff3836ec2ed0e9b08c33b3ec3d29e707b))
* **all:** Auto-regenerate discovery clients ([#2556](https://togithub.com/googleapis/google-api-go-client/issues/2556)) ([fb153c0](https://togithub.com/googleapis/google-api-go-client/commit/fb153c030eb62f149abff30e6948ea1933a9034c))
* Reduce code size by 29% ([#2544](https://togithub.com/googleapis/google-api-go-client/issues/2544)) ([2f2505b](https://togithub.com/googleapis/google-api-go-client/commit/2f2505b83d909fafc4dcf24aff9bb6eb3b7333d7))


### Bug Fixes

* Split large compute file up ([#2546](https://togithub.com/googleapis/google-api-go-client/issues/2546)) ([1b6db6c](https://togithub.com/googleapis/google-api-go-client/commit/1b6db6c4446668599f8db8edda2dde85d7b6015d))
* Temp patch cloud.google.com/go ambiguity ([#2560](https://togithub.com/googleapis/google-api-go-client/issues/2560)) ([3eb92f1](https://togithub.com/googleapis/google-api-go-client/commit/3eb92f1acf25ec8ac4eeb0fa75dbb04a10db36e0)), refs [#2543](https://togithub.com/googleapis/google-api-go-client/issues/2543) [#2559](https://togithub.com/googleapis/google-api-go-client/issues/2559)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants