Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/gensupport): add configurable retry #1324

Merged
merged 10 commits into from Dec 13, 2021

Commits on Dec 1, 2021

  1. feat(internal/gensupport): add configurable retry

    Extend SendAndRetryRequest to allow retry options (backoff and
    ErrorFunc) to be passed in. Add a surface to the generated code
    for storage to allow the manual layer to choose whether the request
    is retried.
    
    I tested this out via the manual layer by verifying that the
    ObjectsInsertCall only retries now when WithRetry() is applied.
    
    I still need to update the generator to ensure that the changes in
    the generated file will persist and probably add some tests as well.
    Thought I'd try and get an initial review first.
    tritone committed Dec 1, 2021
    Copy the full SHA
    0955a27 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Copy the full SHA
    05e09f4 View commit details
    Browse the repository at this point in the history
  2. gofmt

    tritone committed Dec 9, 2021
    Copy the full SHA
    67f78e0 View commit details
    Browse the repository at this point in the history
  3. more refactoring

    tritone committed Dec 9, 2021
    Copy the full SHA
    2629a72 View commit details
    Browse the repository at this point in the history
  4. add generator changes

    tritone committed Dec 9, 2021
    Copy the full SHA
    f233fab View commit details
    Browse the repository at this point in the history
  5. gofmt

    tritone committed Dec 9, 2021
    Copy the full SHA
    0568799 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. fix v1beta2 file

    tritone committed Dec 10, 2021
    Copy the full SHA
    0bd85a2 View commit details
    Browse the repository at this point in the history
  2. remove superfluous else

    tritone committed Dec 10, 2021
    Copy the full SHA
    fb2d239 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    b452afb View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. Copy the full SHA
    4c95618 View commit details
    Browse the repository at this point in the history