feat: Makes ComputeCredential support scopes #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
reviewed
Apr 12, 2022
| /// Scopes to request during the authorization grant. May be null or empty. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// If the scopes are pre-granted through the environement, like in GCE where scopes are granted to the VM, |
There was a problem hiding this comment.
environement => environment
| @@ -153,5 +155,99 @@ public async Task FetchesOidcToken_WithOptions(OidcTokenFormat format, string ta | |||
|
|
|||
| Assert.Equal(expectedQueryString, messageHandler.LatestRequest.RequestUri.Query); | |||
| } | |||
|
|
|||
| public static IEnumerable<object[]> Scoped_WithDefaultTokenUrl_Data | |||
| } | ||
| else | ||
| { | ||
| uriBuilder.Query = $"{uriBuilder.Query.Substring(1)}&{scopesQuery}"; |
There was a problem hiding this comment.
So setting the query you don't want the leading "?" (prior to .NET 5), but fetching it you receive it? That sucks so much.
There was a problem hiding this comment.
Yes, it's all very "weird", some tests failed and some tests didn't when I first just appended the scopes with the potential & only, until I found those docs with the example. Anyway...
| } | ||
|
|
||
| public IEnumerable<HttpRequestMessage> Requests { get => _requests; } |
There was a problem hiding this comment.
Just public IEnumerable<HttpRequestMessage> Requests => _requests;
jskeet
approved these changes
Apr 12, 2022
amanda-tarafa
force-pushed
the
compute-scopes
branch
from
36bbca5
to
f27e4cb
Compare
amanda-tarafa
commented
Apr 19, 2022
| } | ||
| else | ||
| { | ||
| uriBuilder.Query = $"{uriBuilder.Query.Substring(1)}&{scopesQuery}"; |
There was a problem hiding this comment.
Yes, it's all very "weird", some tests failed and some tests didn't when I first just appended the scopes with the potential & only, until I found those docs with the example. Anyway...
| /// Scopes to request during the authorization grant. May be null or empty. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// If the scopes are pre-granted through the environement, like in GCE where scopes are granted to the VM, |
| } | ||
|
|
||
| public IEnumerable<HttpRequestMessage> Requests { get => _requests; } |
| @@ -153,5 +155,99 @@ public async Task FetchesOidcToken_WithOptions(OidcTokenFormat format, string ta | |||
|
|
|||
| Assert.Equal(expectedQueryString, messageHandler.LatestRequest.RequestUri.Query); | |||
| } | |||
|
|
|||
| public static IEnumerable<object[]> Scoped_WithDefaultTokenUrl_Data | |||
jskeet
approved these changes
Apr 19, 2022
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Oct 18, 2022
Features - googleapis#2228 Supports Quota Project environment variable for ADC. - googleapis#2219 Removes obsolete OOB code. BREAKING CHANGE: We have removed OOB support from the library because the feature is not supported by Google OAuth as of October 3rd 2022. See the [official announcement](https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html#disallowed-oob) for more information. - googleapis#2216 Log errors when trying to reach Compute's metadata server. - googleapis#2177, googleapis#2197, googleapis#2200, googleapis#2206, googleapis#2215, googleapis#2235 Support for Workload Identity Federation and Worforce Identity Federation. - googleapis#2103 Compute credentials support explicit scopes. - googleapis#2096 Improves deserialization error handling.
amanda-tarafa
added a commit
that referenced
this pull request
Oct 18, 2022
Features - #2228 Supports Quota Project environment variable for ADC. - #2219 Removes obsolete OOB code. BREAKING CHANGE: We have removed OOB support from the library because the feature is not supported by Google OAuth as of October 3rd 2022. See the [official announcement](https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html#disallowed-oob) for more information. - #2216 Log errors when trying to reach Compute's metadata server. - #2177, #2197, #2200, #2206, #2215, #2235 Support for Workload Identity Federation and Worforce Identity Federation. - #2103 Compute credentials support explicit scopes. - #2096 Improves deserialization error handling.
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Nov 30, 2022
And support version: 1.58.0-beta02 => 1.58.0 Bug fixes: - googleapis#2273 Don't attempt to use an empty/null media type in batch responses - googleapis#2251 Which fixes a typo on then name of one of the AWS Credential environment variables. - googleapis#2264 Which adds a missing line break in AWS Credential canonical request. Features - googleapis#2269 Support per-request max retry configuration. - googleapis#2228 Supports Quota Project environment variable for ADC. - googleapis#2219 Removes obsolete OOB code. BREAKING CHANGE: We have removed OOB support from the library because the feature is not supported by Google OAuth as of October 3rd 2022. See the [official announcement](https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html#disallowed-oob) for more information. - googleapis#2216 Log errors when trying to reach Compute's metadata server. - googleapis#2177, googleapis#2197, googleapis#2200, googleapis#2206, googleapis#2215, googleapis#2235 Support for Workload Identity Federation and Worforce Identity Federation. - googleapis#2103 Compute credentials support explicit scopes. - googleapis#2096 Improves deserialization error handling.
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Nov 30, 2022
And support version: 1.58.0-beta02 => 1.58.0 Dependencies: - Client libraries no longer target netstandard1.0 or net40. Bug fixes: - googleapis#2273 Don't attempt to use an empty/null media type in batch responses - googleapis#2251 Which fixes a typo on then name of one of the AWS Credential environment variables. - googleapis#2264 Which adds a missing line break in AWS Credential canonical request. Features - googleapis#2269 Support per-request max retry configuration. - googleapis#2228 Supports Quota Project environment variable for ADC. - googleapis#2219 Removes obsolete OOB code. BREAKING CHANGE: We have removed OOB support from the library because the feature is not supported by Google OAuth as of October 3rd 2022. See the [official announcement](https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html#disallowed-oob) for more information. - googleapis#2216 Log errors when trying to reach Compute's metadata server. - googleapis#2177, googleapis#2197, googleapis#2200, googleapis#2206, googleapis#2215, googleapis#2235 Support for Workload Identity Federation and Worforce Identity Federation. - googleapis#2103 Compute credentials support explicit scopes. - googleapis#2096 Improves deserialization error handling.
amanda-tarafa
added a commit
that referenced
this pull request
Nov 30, 2022
And support version: 1.58.0-beta02 => 1.58.0 Dependencies: - Client libraries no longer target netstandard1.0 or net40. Bug fixes: - #2273 Don't attempt to use an empty/null media type in batch responses - #2251 Which fixes a typo on then name of one of the AWS Credential environment variables. - #2264 Which adds a missing line break in AWS Credential canonical request. Features - #2269 Support per-request max retry configuration. - #2228 Supports Quota Project environment variable for ADC. - #2219 Removes obsolete OOB code. BREAKING CHANGE: We have removed OOB support from the library because the feature is not supported by Google OAuth as of October 3rd 2022. See the [official announcement](https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html#disallowed-oob) for more information. - #2216 Log errors when trying to reach Compute's metadata server. - #2177, #2197, #2200, #2206, #2215, #2235 Support for Workload Identity Federation and Worforce Identity Federation. - #2103 Compute credentials support explicit scopes. - #2096 Improves deserialization error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is requiered for supporting GKE Workload Identity.
As always, one commit at a time.