fix: add long to protos.d.ts #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
- Coverage 88.42% 88.41% -0.02%
==========================================
Files 65 65
Lines 4140 4145 +5
Branches 320 321 +1
==========================================
+ Hits 3661 3665 +4
Misses 387 387
- Partials 92 93 +1
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protobuf.js PR protobufjs/protobuf.js#1166 was merged ages ago but still not released. I suspect it might take some more time to release it, so - since this script is the one place to generate proto TS file - let's do it from here for now.
It will only add a missing import if it's not there already, so when the the protobuf.js PR is finally released, it won't break and we'll just remove it from here.