fix: use camel case for page token (#173)

* fix: use camel case for page token * Update proto.ts * test: fix baselines
googleapis · Dec 14, 2019 · 8cac8e7 · 8cac8e7
1 parent 88f1e33
commit 8cac8e7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/typescript/src/schema/proto.ts b/typescript/src/schema/proto.ts
@@ -324,7 +324,7 @@ function pagingField(messages: MessagesMap, method: MethodDescriptorProto) {
 
 function pagingFieldName(messages: MessagesMap, method: MethodDescriptorProto) {
   const field = pagingField(messages, method);
-  return field?.name;
+  return field?.name?.toCamelCase();
 }
 
 function pagingResponseType(

diff --git a/typescript/test/testdata/keymanager/src/v1/key_management_service_client.ts.baseline b/typescript/test/testdata/keymanager/src/v1/key_management_service_client.ts.baseline
@@ -141,13 +141,13 @@ export class KeyManagementServiceClient {
     // pages). Denote the keys used for pagination and results.
     this._descriptors.page = {
       listKeyRings:
-          new gaxModule.PageDescriptor('pageToken', 'nextPageToken', 'key_rings'),
+          new gaxModule.PageDescriptor('pageToken', 'nextPageToken', 'keyRings'),
       listCryptoKeys:
-          new gaxModule.PageDescriptor('pageToken', 'nextPageToken', 'crypto_keys'),
+          new gaxModule.PageDescriptor('pageToken', 'nextPageToken', 'cryptoKeys'),
       listCryptoKeyVersions:
-          new gaxModule.PageDescriptor('pageToken', 'nextPageToken', 'crypto_key_versions'),
+          new gaxModule.PageDescriptor('pageToken', 'nextPageToken', 'cryptoKeyVersions'),
       listImportJobs:
-          new gaxModule.PageDescriptor('pageToken', 'nextPageToken', 'import_jobs')
+          new gaxModule.PageDescriptor('pageToken', 'nextPageToken', 'importJobs')
     };
 
     // Put together the default options sent with requests.