New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add system tests to check error details #1076
Conversation
… into googleapis-master
The commit history in this PR is misleading. It contains some of my older commits unrelated to this PR. Any ideas how to fix it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to my comments inline, two things:
- These are unit tests, not system tests (they don't exercise actual over-the-wire API calls).
- They belong in
python-api-core
, not in this repository.
@atulep For future reference, you can rebase your branch against |
@tseaver We want gapic clients to have access to |
@atulep I apologize -- I somehow missed seeing that these tests use the Please do rebase your branch against the current $ git fetch --all --prune
$ git checkout main
$ git checkout error_details
$ git rebase main
$ git push -f origin error_details I would also avoid re-using a branch after merging its PR. |
@tseaver, I followed your script, but it gave me:
Maybe it's easier to start a fresh PR with correct history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not blocker, but please add a test case for error_info
once the feature merged.
Thank you very much. :)
System tests to check error details added in googleapis/python-api-core#286.