Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for grpc only gapic #707

Merged
merged 6 commits into from Apr 25, 2024
Merged

feat: Add support for grpc only gapic #707

merged 6 commits into from Apr 25, 2024

Conversation

Hectorhammett
Copy link
Contributor

@Hectorhammett Hectorhammett commented Apr 23, 2024 •
edited by bshaffer

fixes #705

bshaffer
bshaffer reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also still update the BUILD.bazel file in tests/Integration/Redis and the corresponding goldens, to verify that the Bazel changes worked!

src/Generation/GapicClientV2Generator.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
tests/Unit/ProtoTests/BasicGrpcOnly/basicGrpcOnly.proto Outdated Show resolved Hide resolved
tests/Unit/ProtoTests/BasicGrpcOnly/basicGrpcOnly.proto Outdated Show resolved Hide resolved
tests/Unit/ProtoTests/BasicGrpcOnly/basicGrpcOnly.proto Outdated Show resolved Hide resolved
tests/Unit/ProtoTests/BasicGrpcOnly/basic_grpc_only_service.yaml Outdated Show resolved Hide resolved
This was referenced Apr 25, 2024
Closed
Merged
bshaffer
bshaffer reviewed Apr 25, 2024
View reviewed changes
src/CodeGenerator.php Outdated Show resolved Hide resolved
@Hectorhammett Hectorhammett marked this pull request as ready for review April 25, 2024 19:17
@Hectorhammett Hectorhammett requested review from a team as code owners April 25, 2024 19:17
@bshaffer bshaffer merged commit 5783c98 into main Apr 25, 2024
4 checks passed
@bshaffer bshaffer deleted the grpc-only branch April 25, 2024 19:19
@release-please release-please bot mentioned this pull request Apr 25, 2024
Merged
@bshaffer
Copy link
Contributor

It worked! googleapis/google-cloud-php@c17dce0

@Hectorhammett
Copy link
Contributor Author

@bshaffer Let's gooooo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

@noahdietz noahdietz Awaiting requested review from noahdietz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow for gRPC-only GAPIC libraries
2 participants
@Hectorhammett @bshaffer