Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gapic: remove disable serv config dial opt #812

Merged
merged 2 commits into from Nov 12, 2021
Merged

gapic: remove disable serv config dial opt #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd65ee8
gapic: remove disable serv config dial opt
noahdietz Nov 11, 2021
54ae05d
Merge branch 'master' into remove-disable-serv-conf
noahdietz Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion internal/gengapic/gengrpc.go
View file
Open in desktop
Expand Up @@ -199,7 +199,6 @@ func (g *generator) grpcClientOptions(serv *descriptor.ServiceDescriptorProto, s
p(" internaloption.WithDefaultAudience(%q),", generateDefaultAudience(host))
p(" internaloption.WithDefaultScopes(DefaultAuthScopes()...),")
p(" internaloption.EnableJwtWithScope(),")
p(" option.WithGRPCDialOption(grpc.WithDisableServiceConfig()),")
p(" option.WithGRPCDialOption(grpc.WithDefaultCallOptions(")
p(" grpc.MaxCallRecvMsgSize(math.MaxInt32))),")
p(" }")
Expand Down
1 change: 0 additions & 1 deletion internal/gengapic/testdata/empty_opt.want
View file
Open in desktop
Expand Up @@ -22,7 +22,6 @@ func defaultGRPCClientOptions() []option.ClientOption {
internaloption.WithDefaultAudience("https://foo.googleapis.com/"),
internaloption.WithDefaultScopes(DefaultAuthScopes()...),
internaloption.EnableJwtWithScope(),
option.WithGRPCDialOption(grpc.WithDisableServiceConfig()),
option.WithGRPCDialOption(grpc.WithDefaultCallOptions(
grpc.MaxCallRecvMsgSize(math.MaxInt32))),
}
Expand Down
1 change: 0 additions & 1 deletion internal/gengapic/testdata/foo_opt.want
View file
Open in desktop
Expand Up @@ -22,7 +22,6 @@ func defaultFooGRPCClientOptions() []option.ClientOption {
internaloption.WithDefaultAudience("https://foo.googleapis.com/"),
internaloption.WithDefaultScopes(DefaultAuthScopes()...),
internaloption.EnableJwtWithScope(),
option.WithGRPCDialOption(grpc.WithDisableServiceConfig()),
option.WithGRPCDialOption(grpc.WithDefaultCallOptions(
grpc.MaxCallRecvMsgSize(math.MaxInt32))),
}
Expand Down
1 change: 0 additions & 1 deletion internal/gengapic/testdata/host_port_opt.want
View file
Open in desktop
Expand Up @@ -20,7 +20,6 @@ func defaultBarGRPCClientOptions() []option.ClientOption {
internaloption.WithDefaultAudience("https://foo.googleapis.com/"),
internaloption.WithDefaultScopes(DefaultAuthScopes()...),
internaloption.EnableJwtWithScope(),
option.WithGRPCDialOption(grpc.WithDisableServiceConfig()),
option.WithGRPCDialOption(grpc.WithDefaultCallOptions(
grpc.MaxCallRecvMsgSize(math.MaxInt32))),
}
Expand Down
1 change: 0 additions & 1 deletion internal/gengapic/testdata/iam_override_opt.want
View file
Open in desktop
Expand Up @@ -19,7 +19,6 @@ func defaultBazGRPCClientOptions() []option.ClientOption {
internaloption.WithDefaultAudience("https://foo.googleapis.com/"),
internaloption.WithDefaultScopes(DefaultAuthScopes()...),
internaloption.EnableJwtWithScope(),
option.WithGRPCDialOption(grpc.WithDisableServiceConfig()),
option.WithGRPCDialOption(grpc.WithDefaultCallOptions(
grpc.MaxCallRecvMsgSize(math.MaxInt32))),
}
Expand Down