Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional draft flag to openPullRequest() #207

Merged
merged 5 commits into from Apr 22, 2021

Conversation

SurferJeffAtGoogle
Copy link
Contributor

First step towards Owl Bot opening pull requests. Owl bot invokes this library to open pull requests.

@SurferJeffAtGoogle SurferJeffAtGoogle requested a review from a team April 22, 2021 20:26
@SurferJeffAtGoogle SurferJeffAtGoogle requested a review from a team as a code owner April 22, 2021 20:26
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2021
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #207 (b644983) into master (3d4aa4b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   88.04%   88.07%   +0.03%     
==========================================
  Files          24       24              
  Lines        2301     2307       +6     
  Branches      168      152      -16     
==========================================
+ Hits         2026     2032       +6     
  Misses        275      275              
Impacted Files Coverage Δ
src/github-handler/pull-request-handler.ts 100.00% <100.00%> (ø)
src/index.ts 98.73% <100.00%> (+<0.01%) ⬆️
src/types.ts 98.32% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f440c...b644983. Read the comment docs.

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In docs/tests, can you mention what the default value is

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2021
@SurferJeffAtGoogle
Copy link
Contributor Author

In docs/tests, can you mention what the default value is

My goal is to preserve the behavior of all existing calls to this function. All existing calls passed undefined for draft, so that's what the code continues to do. What does that mean? Octokit doesn't make it clear.

The default value undefined gets passed into octokit, so it's up to octokit to interpret what the default value means. Sadly, octokit's docs do not define what the default value is.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2021
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 22, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit ff9516c into master Apr 22, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the open-draft branch April 22, 2021 23:34
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 22, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants