Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add package-lock.json to fix Docker build #161

Merged
merged 1 commit into from Dec 8, 2020

Conversation

chingor13
Copy link
Contributor

Until we can resolve all the type compilation issues, lock the dependencies for the Docker action.

Fixes #160

@chingor13 chingor13 requested a review from a team December 7, 2020 23:58
@chingor13 chingor13 requested a review from a team as a code owner December 7, 2020 23:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #161 (92cdf10) into master (82593b9) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   87.84%   87.98%   +0.13%     
==========================================
  Files          23       23              
  Lines        2222     2222              
  Branches      161      170       +9     
==========================================
+ Hits         1952     1955       +3     
+ Misses        270      266       -4     
- Partials        0        1       +1     
Impacted Files Coverage Δ
src/github-handler/index.ts 94.73% <0.00%> (-5.27%) ⬇️
src/bin/workflow.ts 81.05% <0.00%> (-1.06%) ⬇️
src/bin/handle-git-dir-change.ts 79.68% <0.00%> (+0.39%) ⬆️
src/github-handler/commit-and-push-handler.ts 98.91% <0.00%> (+0.54%) ⬆️
...ler/make-review-handler/upload-comments-handler.ts 99.31% <0.00%> (+0.68%) ⬆️
...-hunk-scope-handler/remote-patch-ranges-handler.ts 89.91% <0.00%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82593b9...92cdf10. Read the comment docs.

@chingor13 chingor13 merged commit 0d5ecf1 into googleapis:master Dec 8, 2020
@chingor13 chingor13 deleted the lock branch December 8, 2020 00:03
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

action: Persistent failure when building action
2 participants