Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update README partials to mention how to use import #1400

Merged
merged 2 commits into from Nov 16, 2021
Merged

Conversation

dnoe
Copy link
Contributor

@dnoe dnoe commented Nov 9, 2021

GitHub issue #1398 indicates that a specific incantation is required when using "import" with the trace-agent. This PR updates the README to mention this.

Fixes #1398 馃

GitHub issue #1398 indicates that a specific incantation is required when using "import" with the trace-agent. This PR updates the README to mention this.
@dnoe dnoe requested review from a team as code owners November 9, 2021 15:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2021
@product-auto-label product-auto-label bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Nov 9, 2021
@dnoe dnoe changed the title Update READM partials to mention how to use import Update README partials to mention how to use import Nov 9, 2021
@dnoe dnoe changed the title Update README partials to mention how to use import fix: Update README partials to mention how to use import Nov 9, 2021
@dnoe dnoe assigned gkf Nov 9, 2021
@dnoe dnoe merged commit da8741b into main Nov 16, 2021
@dnoe dnoe deleted the dnoe-patch-2 branch November 16, 2021 14:45
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typescript es6 import, TypeError: Cannot read property 'start' of undefined
2 participants