Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

fix: Add more debugging info to the system e2e test #983

Merged
merged 3 commits into from
Jul 6, 2021

Conversation

Louis-Ye
Copy link
Contributor

The e2e test did not seem to fail in the past several months. We tend to close the issue for now with this PR, which adds more debugging information to the e2e test, so that if it failed again in the future, we would have more information to know what's the cause.

Fixes #946

@Louis-Ye Louis-Ye requested review from a team as code owners June 24, 2021 18:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2021
@product-auto-label product-auto-label bot added the api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. label Jun 24, 2021
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #983 (2ad761a) into master (1da960a) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   66.90%   66.78%   -0.12%     
==========================================
  Files          20       20              
  Lines        1668     1668              
  Branches      340      340              
==========================================
- Hits         1116     1114       -2     
- Misses        474      475       +1     
- Partials       78       79       +1     
Impacted Files Coverage Δ
src/agent/debuglet.ts 80.64% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1da960a...2ad761a. Read the comment docs.

@bcoe bcoe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 2, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 2, 2021
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2021
@mctavish mctavish merged commit 5f670ee into googleapis:master Jul 6, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@google-cloud/debug end-to-end behavior: should set breakpoints correctly failed
3 participants